Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernises gapminders #212

Closed
wants to merge 2 commits into from
Closed

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 18, 2022

Addresses a small part of holoviz/panel#4214 by adding a better gapminder reference example to the Panel home page

image

You can use the below assets for promotion :-)

gapminders

gapminders-speedup

gapminders-speedup.mp4

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Dec 18, 2022

@philippjfr should

  • [] Update the anaconda-project.yml to latest versions of the relevant packages including

panel==0.14.2
hvplot==0.8.2
holoviews==1.15.1
param==1.12.2
altair==4.2.0
plotly==5.11.0
matplotlib==3.6.1
pandas==1.5.1

  • [] Fix the failing test (cannot find pytest!)
  • [] Make sure the app gets re-deployed
  • [] Make sure the app is used on the home page of Panel and the thumbnail on the Panel home page is updated to the above.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Dec 18, 2022

FYI @philippjfr. I just tried running panel convert on the code. But it raises

File "/lib/python3.10/site-packages/matplotlib/backends/wasm_backend.py", line 21, in <module>
    from matplotlib.backends.browser_backend import FigureCanvasWasm, NavigationToolbar2Wasm
  File "/lib/python3.10/site-packages/matplotlib/backends/browser_backend.py", line 5, in <module>
    from js import document
ImportError: cannot import name 'document' from 'js' (unknown location)

See pyodide/pyodide#561

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review December 18, 2022 19:23
@philippjfr
Copy link
Contributor

Will have to look into how we can get matplotlib not to assume it's running in the main browser thread. The pyodide-worker convert target creates a web worker so any pyodide that accesses the DOM won't work in there and matplotlib seems to switch to a WASM rendering backend that requires DOM access.

@maximlt maximlt mentioned this pull request Oct 31, 2023
@maximlt maximlt removed the ready label Oct 31, 2023
@maximlt maximlt closed this Nov 1, 2023
@maximlt maximlt deleted the feature/modernize-gapminders branch October 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants